[repo] generate version.py in Makefile #14791
Open
+186
−263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehigham
force-pushed
the
ehigham/generate-hail-version
branch
3 times, most recently
from
b42f83c to
572f03a
Compare
ehigham
force-pushed
the
ehigham/generate-hail-version
branch
from
aed9c05 to
85a821b
Compare
ehigham
commented
Jan 23, 2025
Comment on lines
+26
to
+31
| def __load_module(name, path): | ||
| spec = spec_from_file_location(name, path) | ||
| mod = module_from_spec(spec) | ||
| sys.modules[name] = mod | ||
| spec.loader.exec_module(mod) | ||
| return mod |
There was a problem hiding this comment.
This is arguably the only more complicated bit about this change. I could have used a regex to read extract this information but settled on this as I believe it would fail if we changed versioning in the future and forgot to modify this.
There was a problem hiding this comment.
TIL this was possible. Pretty cool.
cjllanwarne
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
The change looks good to me, and I have confirmed this makes its way through to the API responses correctly. Could you please add a security comment ala https://github.com/hail-is/hail/blob/main/.github/pull_request_template.md ?
Comment on lines
+26
to
+31
| def __load_module(name, path): | ||
| spec = spec_from_file_location(name, path) | ||
| mod = module_from_spec(spec) | ||
| sys.modules[name] = mod | ||
| spec.loader.exec_module(mod) | ||
| return mod |
There was a problem hiding this comment.
TIL this was possible. Pretty cool.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This generates the hail version in a way that's importable in python and javascript (for webpages). It simplifies how the version is used in those languages as well as the number of files we need to juggle in CI.